Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Gitlab provider #27

Merged
merged 68 commits into from
Dec 24, 2024
Merged

feat: Gitlab provider #27

merged 68 commits into from
Dec 24, 2024

Conversation

omri2001
Copy link
Contributor

Add support for GitLab as a provider

@omri2001 omri2001 requested a review from GoshaDo as a code owner December 24, 2024 09:17
@GoshaDo
Copy link
Contributor

GoshaDo commented Dec 24, 2024

@ssliman moved to this PR

@ssliman
Copy link
Contributor

ssliman commented Dec 24, 2024

Thanks! looking forward to test this out. Will it be merged this week?

@GoshaDo GoshaDo merged commit 8974887 into main Dec 24, 2024
7 checks passed
@GoshaDo GoshaDo deleted the gitlab-provider branch December 24, 2024 13:19
@GoshaDo
Copy link
Contributor

GoshaDo commented Dec 24, 2024

Thanks! looking forward to test this out. Will it be merged this week?

merged.
will be great to get your feedback :)

@ssliman
Copy link
Contributor

ssliman commented Jan 6, 2025

@GoshaDo I've set it up with our selfhosted gitlab and it works. Thank you for providing this support.

One missing feature that could be implemented is that we have multiple gitlab groups and currently with the current piper version we only provide 1 group through the values.yaml

  piper:
    gitProvider:
      name: gitlab
      # Map of organization configurations.
      organization:
        # -- Name of your Git Organization (GitHub) / Workspace (Bitbucket) or Group (Gitlab)
        name: "private/k8s"
      # Map of webhook configurations.
      webhook:
        # -- (Github/Gitlab) Used of orgLevel=false, to configure webhook for each of the repos provided.
        repoList: ["some-repo"]

if we want repositories from other groups that's not possible.

EDIT: fixed some naming for confusion

@GoshaDo
Copy link
Contributor

GoshaDo commented Jan 6, 2025

@GoshaDo I've set it up with our selfhosted gitlab and it works. Thank you for providing this support.

One missing feature that could be implemented is that we have multiple gitlab projects and currently with the current piper version we only provide 1 project through the values.yaml

  piper:
    gitProvider:
      name: gitlab
      # Map of organization configurations.
      organization:
        # -- Name of your Git Organization (GitHub) / Workspace (Bitbucket) or Group (Gitlab)
        name: "private/k8s"
      # Map of webhook configurations.
      webhook:
        # -- (Github/Gitlab) Used of orgLevel=false, to configure webhook for each of the repos provided.
        repoList: ["some-repo"]

if we want repositories from other groups/projects that's not possible.

@omri2001 Interesting feature..
@ssliman Can you please open an issue with the description (That you just provided) so you can be updated automatically for the progress of this issue ?

@GoshaDo
Copy link
Contributor

GoshaDo commented Jan 6, 2025

@ssliman btw, if you configure the webhook in project level manually , it should work..
The secret for authentication can be found in K8s secret, where piper installed..
Screenshot 2025-01-06 at 13 39 51

@ssliman
Copy link
Contributor

ssliman commented Jan 6, 2025

@GoshaDo thanks indeed. Yes it does work, but if you have like a lot of repositories across different groups that's a lot of manual work. I could create a script that does it for me. It would be nice if it's handled by piper automatically.

@ssliman
Copy link
Contributor

ssliman commented Jan 6, 2025

Feature request created under #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants