Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different versions for nox and maturin build #255

Closed
alex-au-922 opened this issue Apr 28, 2024 · 4 comments
Closed

Different versions for nox and maturin build #255

alex-au-922 opened this issue Apr 28, 2024 · 4 comments

Comments

@alex-au-922
Copy link
Contributor

I have found that the python interpreter versions for maturin and nox are in different versions:

# Makefile

build:
	maturin build --interpreter python3.7 python3.8 python3.9 python3.10 python3.11
#noxfile.py

@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
def test(session):
    session.install("-rrequirements-dev.txt")
    session.install("-e", ".", "--no-build-isolation")
    session.run("pytest", *session.posargs)

Will this lead to unexpected behavior?

@cjrh
Copy link
Collaborator

cjrh commented May 3, 2024

I don't think that makefile is used anywhere. The CI doesn't, for example. I think we should just delete it.

@cjrh cjrh closed this as completed in 22b44a3 May 3, 2024
@alex-au-922
Copy link
Contributor Author

I think the makefile is still useful for testing. It helps me build the latest tantivy (local) binary for my testing in one command, I think we should not discard it.

@cjrh
Copy link
Collaborator

cjrh commented May 12, 2024

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?

Could you describe your workflow in more detail?

@alex-au-922
Copy link
Contributor Author

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?

Could you describe your workflow in more detail?

Oops I just found that the nox command does its job. The Makefile should be safe to discard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants