refactor tokenization pipeline to use GATs #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 94.46% 94.44% -0.02%
==========================================
Files 309 309
Lines 56485 56537 +52
==========================================
+ Hits 53360 53399 +39
- Misses 3125 3138 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Mar 8, 2023
fulmicoton
reviewed
Mar 8, 2023
| EmptyTokenStream::default().into() | ||
| type TokenStream<'a> = EmptyTokenStream; | ||
| fn token_stream<'a>(&self, _text: &'a str) -> EmptyTokenStream { | ||
| EmptyTokenStream::default() |
There was a problem hiding this comment.
Suggested change
| EmptyTokenStream::default() | |
| EmptyTokenStream |
There was a problem hiding this comment.
EmptyTokenStream isn't an empty struct, it contains a default Token
fulmicoton
reviewed
Mar 8, 2023
fulmicoton
reviewed
Mar 8, 2023
fulmicoton
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #1654, I found a substantial part of the difference between "normal" strings and pre-split strings is the amount of allocation/deallocation done. It's one per string and per filter, as filter take a
BoxTokenStreamand returns aBoxTokenStream. This leverage GATs so only the the finalTokenStreamget boxed.I've also found that pre-allocating a String for the LowerCaser is harmful to performance if some strings may be ascii only, which happens a lot more when strings are pre-split (and making matters worse, a lot more
LowerCaserTokenStreamare also instantiated in that case).Measuring on
fmassot--bench-hdfs-with-array, I get a 3% uplift in the general case, and a 19% with pre-split strings.