Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to ms in histogram for date type #2045

Merged
merged 8 commits into from
May 19, 2023
Merged

switch to ms in histogram for date type #2045

merged 8 commits into from
May 19, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented May 16, 2023

switch to ms in histogram, by adding a normalization step that converts
to nanoseconds precision when creating the collector.

closes #2028
related to #2026

PSeitz added 2 commits May 16, 2023 15:30
switch to ms in histogram, by adding a normalization step that converts
to nanoseconds precision when creating the collector.

closes #2028
related to #2026
@PSeitz PSeitz requested a review from fulmicoton May 16, 2023 08:19
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #2045 (ae94bf2) into main (2dfe379) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2045      +/-   ##
==========================================
- Coverage   94.43%   94.43%   -0.01%     
==========================================
  Files         319      319              
  Lines       59633    59706      +73     
==========================================
+ Hits        56313    56381      +68     
- Misses       3320     3325       +5     
Impacted Files Coverage Δ
src/aggregation/agg_req.rs 94.11% <ø> (ø)
src/aggregation/agg_req_with_accessor.rs 100.00% <ø> (ø)
src/aggregation/bucket/mod.rs 96.15% <ø> (ø)
src/aggregation/intermediate_agg_result.rs 94.84% <ø> (-0.07%) ⬇️
src/aggregation/metric/percentiles.rs 89.48% <ø> (ø)
src/aggregation/mod.rs 91.87% <ø> (ø)
columnar/src/columnar/column_type.rs 72.22% <100.00%> (+0.95%) ⬆️
src/aggregation/bucket/histogram/date_histogram.rs 97.27% <100.00%> (+0.01%) ⬆️
src/aggregation/bucket/histogram/histogram.rs 99.46% <100.00%> (+0.01%) ⬆️
src/aggregation/segment_agg_result.rs 95.68% <100.00%> (ø)

... and 5 files with indirect coverage changes

@PSeitz PSeitz merged commit 6239697 into main May 19, 2023
@PSeitz PSeitz deleted the agg_millisecs branch May 19, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date histogram should return keys in milliseconds to be compatible with ES
3 participants