Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't bump Jetty to 9.4.45 #942

Closed
tresf opened this issue Mar 18, 2022 · 1 comment
Closed

Can't bump Jetty to 9.4.45 #942

tresf opened this issue Mar 18, 2022 · 1 comment

Comments

@tresf
Copy link
Contributor

tresf commented Mar 18, 2022

When attempting to bump Jetty to 9.4.45, I receive the following NullPointerException:

java.lang.NullPointerException: Cannot invoke "org.eclipse.jetty.websocket.server.NativeWebSocketConfiguration.addMapping(org.eclipse.jetty.http.pathmap.PathSpec, org.eclipse.jetty.websocket.servlet.WebSocketCreator)" because "this.configuration" is null
	at org.eclipse.jetty.websocket.server.WebSocketUpgradeFilter.addMapping(WebSocketUpgradeFilter.java:157)
	at qz.ws.PrintSocketServer.runServer(PrintSocketServer.java:167)
	at qz.ws.PrintSocketServer.main(PrintSocketServer.java:113)

Upon further investigation, it appears there was a change to how WebsocketUpgradeFilter.configure(...) initializes its internal configuration object. I'm not sure if this change was intentional.

A temporary workaround is to fallback to the @Deprecated configureContext(...) API call, however this is just a stop-gap as the permanent solution is to ensure the filter's internal configuration isn't null.

@tresf
Copy link
Contributor Author

tresf commented Mar 23, 2022

Closed via #943, #936

@tresf tresf closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants