Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.6.0 release candidate #896

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

v1.6.0 release candidate #896

wants to merge 9 commits into from

Conversation

simonpcouch
Copy link
Collaborator

Closes #895.

ℹ Check [email protected] for the results in 15-30 mins (~12:17 PM).

ℹ Creating cloud job "bfbefa9b-56d2-4805-8ad9-711bd24b240f"

@simonpcouch
polish NEWS
b147b31
@simonpcouch
urlchecker::url_check()
7a41768
@simonpcouch
resolve global variables NOTE
eee2df7
@simonpcouch
redocument()
905d920
@simonpcouch
change 301ing URLs at their R source, too
ac82062
@simonpcouch
remove note on sys headers WARNING, update revdep count
07040b6
@simonpcouch
Resolve "\link{} targets missing package
828a73c 
anchors" NOTE

re`document()`s with dev DBI + adjusts one manual `\link{}` in a source file
@simonpcouch
resolve "\link{} targets missing package" NOTE
78fae8c 
Resolves:

```
* checking Rd cross-references ... NOTE
Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  OdbcConnection.Rd: DBIObject-class, DBIDriver-class,
    DBIConnection-class, DBIResult-class, dbBind
  OdbcResult.Rd: DBIObject-class, DBIDriver-class, DBIConnection-class,
    DBIResult-class
  dbConnect-OdbcDriver-method.Rd: dbListTables, dbSendQuery,
    dbColumnInfo, dbFetch
  odbcConnectionColumns.Rd: dbListFields, dbWriteTable
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.
```

Manually documents `@param dbObj` for a few methods rather than inheriting links to classes that don't resolve automatically.
@simonpcouch simonpcouch changed the title v0.6.0 release candidate v1.6.0 release candidate Feb 11, 2025
@simonpcouch simonpcouch marked this pull request as ready for review February 11, 2025 23:50
@simonpcouch
Copy link
Collaborator Author

Should be ready for usethis::use_version('minor') and devtools::submit_cran()!

@simonpcouch simonpcouch requested a review from hadley February 11, 2025 23:51
@simonpcouch
one more round of "\link{} targets missing package" NOTEs
372587e 
forgot to commit + push after resolving🙃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release odbc 1.6.0
1 participant
@simonpcouch