You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A new fastmap filled with exactly 32 items will have no holes. When serialized and unserialized, the resulting object provides the wrong result for as_list():
This line is supposed to remove the original vector with n_holes items removed. However, when n_holes is 0, then holes is a length-0 vector, and x[-integer(0)] will return an empty vector instead of what we want, which is just the original x unchanged.
The text was updated successfully, but these errors were encountered:
A new
fastmap
filled with exactly 32 items will have no holes. When serialized and unserialized, the resulting object provides the wrong result foras_list()
:This is because of this line:
fastmap/R/fastmap.R
Line 435 in 1d7890c
This line is supposed to remove the original vector with
n_holes
items removed. However, whenn_holes
is 0, thenholes
is a length-0 vector, andx[-integer(0)]
will return an empty vector instead of what we want, which is just the originalx
unchanged.The text was updated successfully, but these errors were encountered: