Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subsume assignment_spaces_linter as part of infix_spaces_linter #914

Closed
MichaelChirico opened this issue Mar 6, 2022 · 2 comments · Fixed by #931
Closed

Subsume assignment_spaces_linter as part of infix_spaces_linter #914

MichaelChirico opened this issue Mar 6, 2022 · 2 comments · Fixed by #931

Comments

@MichaelChirico
Copy link
Collaborator

Follow-up from

https://github.com/AshesITR/lintr/pull/1#discussion_r820137602

is there any reason to treat <- differently than other infix operators?

is it sufficient to just toggle which operators to exclude with an argument to the linter?
@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Mar 13, 2022 •
edited
Loading

infix_spaces_linter already triggers a lint:

lintr::lint("a<-1\n", lintr::infix_spaces_linter())
# <text>:1:2: style: Put spaces around all infix operators.
# a<-1
# ~^~~

@MichaelChirico
Copy link
Collaborator Author

Turns out assignment_spaces_linter was added in this release 😅 #538

@MichaelChirico MichaelChirico mentioned this issue Mar 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extend infix_spaces_linter to be more flexible & correct r-lib/lintr
1 participant
@MichaelChirico