Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add root argument #430

Closed
Tracked by #390
gaborcsardi opened this issue Jan 7, 2025 · 1 comment
Closed
Tracked by #390

add root argument #430

gaborcsardi opened this issue Jan 7, 2025 · 1 comment

Comments

@gaborcsardi
Copy link
Member

No description provided.

@gaborcsardi
Copy link
Member Author

Closed by #433.

Although I might need to change the semantics because it does not seem to make sense to have a root if some paths are not included in it. It also does not seem to make sense to have NA_character_ for root, because renv also read the ignore files from the subdirectories.

Maybe if root = NA_character_ then we don't read any ignore files and treat path as individual files, ignoring their path, essentially.

In general this is way too complicated for use cases that rarely ever happen, so I am not happy with it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant