Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives due to timestamps in CRAN checks #128

Closed
lionel- opened this issue Oct 30, 2020 · 3 comments
Closed

False negatives due to timestamps in CRAN checks #128

lionel- opened this issue Oct 30, 2020 · 3 comments
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@lionel-
Copy link
Member

lionel- commented Oct 30, 2020

Comparing against CRAN checks causes false failures because they include timestamps:

[[1]]
── R CMD check comparison ───────────────────────────── HyperbolicDist 0.6-2 / 0.6-2 ────
Status: BROKEN

── Fixedchecking R code for possible problems ... [21s/24s] NOTE

── Newly failingchecking R code for possible problems ... NOTE


[[2]]
── R CMD check comparison ───────────────────────────────── GlobalDeviance 0.4 / 0.4 ────
Status: BROKEN

── Fixedchecking R code for possible problems ... [6s/8s] NOTE

── Still failingchecking DESCRIPTION meta-information ... NOTE

── Newly failingchecking R code for possible problems ... NOTE

Perhaps these could be safely stripped with a simple regexp?

@gaborcsardi
Copy link
Member

Yeah, or we could have an option to not include them at all. I am actually surprised that they are included.

@lionel-
Copy link
Member Author

lionel- commented Oct 31, 2020

This seems to solve it: b5f1fbd

@gaborcsardi
Copy link
Member

gaborcsardi commented Oct 31, 2020

Right, we should probably remove it from the local checks as well, in case they are requested via an option.

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Apr 27, 2021
@gaborcsardi gaborcsardi added this to the 2.0.0 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants