Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.0-beta03] Navgraphs.* cannot be imported in the generated NavGraphs #630

Closed
SorrowBlue opened this issue May 5, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@SorrowBlue
Copy link

I had a problem after updating to 2.1.0-beta03. No problem with 2.1.0-beta02.

I created MainGraph in the app module and only included XXXDestination and XXXXNavGraph in another module.
※There is no @Destination<MainGraph> in the app module.

@NavHostGraph
annotation class MainGraph {

    @ExternalNavGraph<BookshelfNavGraph>(start = true)
    @ExternalDestination<FavoriteAddScreenDestination>
    companion object Includes
}

navgraphs.* cannot be imported in the generated NavGraphs.
image

This problem does not occur if create a destination that is not used.

@Destination<MainGraph>
@Composable
fun EmptyScreen() {}
@raamcosta
Copy link
Owner

Definitely seems like a bug.
Will look into it later in the evening, thank you for reporting 🙏

@raamcosta raamcosta added the bug Something isn't working label May 5, 2024
@raamcosta raamcosta changed the title navgraphs.* cannot be imported in the generated NavGraphs [2.1.0-beta03] Navgraphs.* cannot be imported in the generated NavGraphs May 5, 2024
@raamcosta
Copy link
Owner

beta04 builds are running, expect to see them available in about 30min or so.

Let me know that it fixed the issue! Thank you once again.

@szymonchaber
Copy link

szymonchaber commented May 15, 2024

@raamcosta This fix is super important for multi-module projects, so it would be great to add that to releases tab in the repository as well, so others will know about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants