Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this library has same issue #83

Closed
binlaniua opened this issue May 13, 2022 · 3 comments
Closed

this library has same issue #83

binlaniua opened this issue May 13, 2022 · 3 comments
Assignees
@lukebakken

Comments

@binlaniua
Copy link

see (streadway/amqp#489)
@lukebakken
Copy link
Contributor

I see you have fixed the issue here -

streadway/amqp#489 (comment)

If you have time, we would appreciate a pull request with a test that demonstrates the issue and that it is fixed. Thanks!

@lukebakken lukebakken self-assigned this May 16, 2022
@lukebakken lukebakken added this to the 1.4.0 milestone May 16, 2022
@lukebakken
Copy link
Contributor

lukebakken commented May 20, 2022 •
edited
Loading

After researching this issue, it appears it would only surface if your consumer is slow, and you are using auto-ack. Is this correct?

@lukebakken lukebakken removed this from the 1.4.0 milestone May 20, 2022
@lukebakken
Copy link
Contributor

Please see my comment - streadway/amqp#489 (comment)

autoAck with a slow consumer is a bad practice with RabbitMQ. Use acks if you have slow consumers.

@lukebakken lukebakken closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2022
@lukebakken lukebakken mentioned this issue May 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukebakken @binlaniua