-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: comparative benchmarks with lodash #258
Draft
MarlonPassos-git
wants to merge
75
commits into
radashi-org:main
Choose a base branch
from
MarlonPassos-git:feature/comparative-benchmarks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: comparative benchmarks with lodash #258
MarlonPassos-git
wants to merge
75
commits into
radashi-org:main
from
MarlonPassos-git:feature/comparative-benchmarks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amel,cloneDeep,flat,diff): add benchmark tests for lodash and radashi
…nt): add benchmark tests for lodash and radashi
MarlonPassos-git
added
in progress
Things being worked on
maintenance
An improvement to codebase maintainability
labels
Sep 28, 2024
…since we run tests in Node 18 and Node 20 environments, which appear to not support `node:` protocol.
This reverts commit 300efa9.
These were intended for non-CI releases, which are now forbidden.
…and optional properties handling.
Co-authored-by: Alec Larson <[email protected]> Co-authored-by: Marlon Passos <[email protected]>
This also reverts 0e0ff04.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary ()
comparisons
folder, and make comparatives benchmarks withlodash
bench
scriptWhile I'm working i am adding some notes to my fork of this
lodash_parity.md
I changed the structure recommended by @aleclarson a bit because I ended up preferring to group the describers by {function} {variant}, as it allows me to have an easier visualization in the stdout of which library is faster in each function and case. In the future, I think it would be interesting to generate a .md file with this result.
bench removed
There are some bethmarks that exist for Radash but they are not able to have backward compatibility with Lodash. They ended up throwing errors during execution.
isPlainObject
Problem to run multiples benchs
When i try run more then 10 benchs alwares the bench fail with some memory leak error,
when i change the pool option to
threads
when we run the benchmark. It improve a litle, but still keeps throwing memory errorsI see some related issues However, the PR they made to vitest has not been uploaded to NPM so I will be testing it when it is available.
I will continue adding the other missing bench cases, but until this memory problem is resolved, we will not be able to approve it.
Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No