Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collection assets in new examples #1013

Closed
cholmes opened this issue Feb 24, 2021 · 1 comment · Fixed by #1023
Closed

Use collection assets in new examples #1013

cholmes opened this issue Feb 24, 2021 · 1 comment · Fixed by #1023
Assignees
Labels
prio: should-have would be very good to have in the release
Milestone

Comments

@cholmes
Copy link
Contributor

cholmes commented Feb 24, 2021

We moved collection assets to core with #1008 but the new examples refresh in #955 hadn't landed when that PR was made, so we just removed the old examples. But we should make sure that the new examples show at least one instance of a collection asset.

@cholmes cholmes added this to the 1.0.0-RC.1 milestone Feb 24, 2021
@cholmes cholmes added the prio: should-have would be very good to have in the release label Feb 24, 2021
@cholmes
Copy link
Contributor Author

cholmes commented Feb 24, 2021

Easiest way to do this is just add a thumbnail in one or more of the collections

"assets": {
    "thumbnail": {
      "href": "thumbnail.png",
      "title": "Preview",
      "type": "image/png",
      "roles": [
        "thumbnail"
      ]
    }
  },

@cholmes cholmes mentioned this issue Feb 24, 2021
4 tasks
@cholmes cholmes self-assigned this Feb 25, 2021
@cholmes cholmes mentioned this issue Mar 2, 2021
3 tasks
@m-mohr m-mohr linked a pull request Mar 3, 2021 that will close this issue
3 tasks
@m-mohr m-mohr closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: should-have would be very good to have in the release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants