Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: CAPTCHA verification failed. #91

Closed
minutetominute opened this issue Aug 10, 2024 · 3 comments · Fixed by #92
Closed

Error: CAPTCHA verification failed. #91

minutetominute opened this issue Aug 10, 2024 · 3 comments · Fixed by #92
Assignees
Labels
bug Something isn't working

Comments

@minutetominute
Copy link

Reproducing the bug:

  1. Submit a moment with a valid captcha verification and without a location
  2. Receive submission because of missing location
  3. Select a location from the map
  4. Receive alert with 'Error: CAPTCHA verification failed.'

output

@jokroese
Copy link
Member

Thanks for sharing this bug @minutetominute!

Currently, the captcha verification runs when the user opens the add modal. If there are issues with sending the moment the first time (i.e. invalid input like in your example) or a long time passes, that verification code can lose its validity.

To fix this, we should move the verification later in the process so that it is:

  1. Open add modal
  2. Write text
  3. Confirm moment (valid location and text)
  4. Get captcha verification (moved from after 'open add modal')
  5. Send moment

@jokroese
Copy link
Member

@narcode, do you have any time to look at this?

@narcode
Copy link
Collaborator

narcode commented Aug 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants