From 019d614e6e79d5d95ab3bf9ddbeffc845268f756 Mon Sep 17 00:00:00 2001 From: Sylvain Niles Date: Fri, 21 Apr 2023 11:09:58 -0700 Subject: [PATCH 1/3] Revert "Stop build if coverage is lower than main (#5300)" This reverts commit e5018721d7481ddef4d89fe9262533abaa34bdeb. --- .github/workflows/build.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index bc1869739d..cbe2a7f68e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -113,9 +113,6 @@ jobs: COLOR=green fi - DIFF_RATE=$(echo "$UT_COVERAGE-$MAIN_COVERAGE" | bc -l) - echo "diff_coverage=$DIFF_RATE" >> $GITHUB_ENV - echo "coverage_img=https://img.shields.io/badge/coverage-$UT_COVERAGE%25-$COLOR" >> $GITHUB_ENV # copy coverage to cache cp ./dist/ut_coverage.txt ./dist/cache/ @@ -151,14 +148,8 @@ jobs: * Your PR branch coverage: ${{ env.ut_coverage }} % * main branch coverage: ${{ env.main_coverage }} % - * diff coverage: ${{ env.diff_coverage }} % > The coverage result does not include the functional test coverage. - - name: Stop build if PR branch coverage is lower than main branch. - if: (env.main_coverage > env.ut_coverage) && matrix.target_arch == 'amd64' && matrix.target_os == 'linux' && github.event.pull_request - run: | - echo "stop build to prevent from merging PR because coverage is down from ${{ env.main_coverage }} % to ${{ env.ut_coverage }} %." - exit 1 - name: Save coverage (only main push) uses: actions/cache/save@v3 if: matrix.target_arch == 'amd64' && matrix.target_os == 'linux' && github.ref == 'refs/heads/main' From 3efdc9bc400df3158e3fdff48bc116b43df19c2d Mon Sep 17 00:00:00 2001 From: Sylvain Niles Date: Fri, 21 Apr 2023 18:14:14 -0700 Subject: [PATCH 2/3] adding diff back in --- .github/workflows/build.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index cbe2a7f68e..5994f8007f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -148,6 +148,7 @@ jobs: * Your PR branch coverage: ${{ env.ut_coverage }} % * main branch coverage: ${{ env.main_coverage }} % + * diff coverage: ${{ env.diff_coverage }} % > The coverage result does not include the functional test coverage. - name: Save coverage (only main push) From bde0f3f00e832c00e3be722abcfeff1f5b62f63d Mon Sep 17 00:00:00 2001 From: Sylvain Niles Date: Mon, 24 Apr 2023 09:21:10 -0700 Subject: [PATCH 3/3] Update build.yaml adding diff rate back to report --- .github/workflows/build.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5994f8007f..241310bbbe 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -112,6 +112,9 @@ jobs: else COLOR=green fi + + DIFF_RATE=$(echo "$UT_COVERAGE-$MAIN_COVERAGE" | bc -l) + echo "diff_coverage=$DIFF_RATE" >> $GITHUB_ENV echo "coverage_img=https://img.shields.io/badge/coverage-$UT_COVERAGE%25-$COLOR" >> $GITHUB_ENV # copy coverage to cache