Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@radix-ui/react-scroll-area] Issue with React 19 and Element Refs #2933

Closed
b0yblake opened this issue Jun 4, 2024 · 2 comments · Fixed by #2934
Closed

[@radix-ui/react-scroll-area] Issue with React 19 and Element Refs #2933

b0yblake opened this issue Jun 4, 2024 · 2 comments · Fixed by #2934

Comments

@b0yblake
Copy link

b0yblake commented Jun 4, 2024

React 19 support

Current Behavior

While testing with React 19, I noticed a warning related to the way element refs are handled. React 19 turns element refs into props.

image

Expected behavior

While this might not be a critical issue right now, the warning appears consistently.

Suggested solution

The ideal solution would be to fully implement the change of turning refs into props, as intended by React 19. This might require some effort and time, but it would eliminate the warning and align with React's best practices.

Let me know if you'd like further revisions!

Additional context

Your environment

Software Name(s) Version
Radix Package(s) @radix-ui/react-scroll-area 1.0.5
React n/a ^19.0.0-rc-38e3b23483-20240529
Browser Chrome
Assistive tech n/a
Node n/a v18.18.0
npm/yarn 1.22.19
Operating System
@vladmoroz
Copy link
Contributor

This is fixed in the new release candidate versions – please let us know if you run into any other issues with React 19

@b0yblake
Copy link
Author

This is fixed in the new release candidate versions – please let us know if you run into any other issues with React 19

This is fantastic! I appreciate your & team hard work. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants