Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The signatures for closeChannel() and updateBalanceProof() should use different message IDs #1149

Closed
pirapira opened this issue Jul 30, 2019 · 0 comments · Fixed by #1150
Closed

The signatures for closeChannel() and updateBalanceProof() should use different message IDs #1149

pirapira opened this issue Jul 30, 2019 · 0 comments · Fixed by #1150
Assignees
@pirapira
Labels
bug Something isn't working efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever
Milestone
Alderaan

Comments

@pirapira
Copy link
Contributor

Currently, these two calls have exactly the same signature validation with the same message IDs, but since the messages have different message IDs, the signature validations should use different message IDs.
@pirapira pirapira mentioned this issue Jul 30, 2019
Merged
@pirapira pirapira added bug Something isn't working P1 urgent, blocker, or makes life easier forever efforts: low_hanging_fruit labels Jul 30, 2019
@pirapira pirapira added this to the next mainnet deployment milestone Jul 30, 2019
@pirapira pirapira self-assigned this Jul 30, 2019
@pirapira pirapira mentioned this issue Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
bug Something isn't working efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
Alderaan
Development

Successfully merging a pull request may close this issue.

Differentiate close and update signature checks pirapira/raiden-contracts
1 participant
@pirapira