Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compile_contracts should also compile contract/services? #365

Closed
pirapira opened this issue Dec 6, 2018 · 4 comments
Closed

make compile_contracts should also compile contract/services? #365

pirapira opened this issue Dec 6, 2018 · 4 comments

Comments

@pirapira
Copy link
Contributor

pirapira commented Dec 6, 2018

Currently, make compile_contracts compile only sol files in contracts and contracts/test. When I change a file in contracts/services, I don't get any update in contracts.json. Is this intended? Or should contracts/services be also compiled?

@loredanacirstea
Copy link
Contributor

I answered here: #360 (comment), where a discussion on this was already started.
tl;dr: we can include them in the compiled data.

The services contracts were left out because they were scoped out of Red Eyes and work on them was discontinued.

@pirapira
Copy link
Contributor Author

pirapira commented Dec 6, 2018

OK. Sorry for the duplicate.

@pirapira pirapira closed this as completed Dec 6, 2018
@loredanacirstea
Copy link
Contributor

loredanacirstea commented Dec 6, 2018

Ah, it is not really a duplicate, as the discussion was on an unmerged PR. I would leave this issue open, because it describes the problem more clearly, thank you.

@loredanacirstea
Copy link
Contributor

#360 was merged. Service contracts were included in the compiled data, because this is what the raiden-contracts package exports for other projects to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants