Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix transport must leave unused rooms #3262

Closed
hackaugusto opened this issue Jan 14, 2019 · 5 comments
Closed

Matrix transport must leave unused rooms #3262

hackaugusto opened this issue Jan 14, 2019 · 5 comments
Labels
Component / Transport Transport related issues

Comments

@hackaugusto
Copy link
Contributor

The logic to leave rooms was disabled as part of a bug fix and needs to be re-enabled. reference
@hackaugusto hackaugusto added the Component / Transport Transport related issues label Jan 14, 2019
@hackaugusto hackaugusto added this to the Ithaca milestone Jan 14, 2019
@hackaugusto hackaugusto mentioned this issue Jan 14, 2019
Merged
@ulope ulope added the P2 label Jan 14, 2019
@ulope
Copy link
Collaborator

ulope commented Jan 14, 2019

This can only be fixed after we increase test coverage on the transport and have a reliable test that can tell us if we re-introduce hanging transfers.

@hackaugusto
Copy link
Contributor Author

should we have another issue for the test?

@LefterisJP
Copy link
Contributor

There is a meta one. Perhaps it can be added there: #3124

@err508 err508 mentioned this issue Mar 26, 2019
Closed
@palango palango removed this from the Ithaca milestone Jun 20, 2019
@err508 err508 mentioned this issue Jul 29, 2019
Merged
@rakanalh rakanalh removed the P2 label Oct 28, 2019
@ulope
Copy link
Collaborator

ulope commented Jan 13, 2020

Will be addressed by #5572

@karlb
Copy link
Contributor

karlb commented Nov 18, 2021

We don't use any rooms anymore.

@karlb karlb closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component / Transport Transport related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ulope @palango @karlb @rakanalh @hackaugusto @LefterisJP