Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract server discovery and shared room discovery / creation into utility function #3291

Closed
2 tasks done
ulope opened this issue Jan 21, 2019 · 2 comments · Fixed by #3393
Closed
2 tasks done

Extract server discovery and shared room discovery / creation into utility function #3291

ulope opened this issue Jan 21, 2019 · 2 comments · Fixed by #3393
Assignees
Labels

Comments

@ulope
Copy link
Collaborator

ulope commented Jan 21, 2019

Abstract

Sub-issue from #3243.
In the initial implementation the MS needs to be able to join a fully federated global room to receive balance proofs from Raiden clients.
Extract the server discovery / login mechanism and discovery room creation mechanism from the MatrixTransport into a utility function, this will provide a temporary solution to the MS until #3252 is implemented and the full MatrixTransport can be used by the MS.

Tasks

  • Extract server discovery, login
  • Extract shared room creation

Time estimation

1 Week

@ulope ulope added Component / Transport Transport related issues Component / MS labels Jan 21, 2019
@ulope ulope changed the title Extract shared room discovery / creation into utility function Extract server discovery and shared room discovery / creation into utility function Jan 21, 2019
@andrevmatos
Copy link
Contributor

I think creation of the room should be quite easy, but this issue must also track filter receiving/sending logic for these special rooms, since all send/receive logic holds certain assumptions about p2p architecture (e.g. send_async expects a peer address, receiving messages filters by invited-by peers). In this case, raiden transport should only send, not care about receiving, but some care must be put on this part as well

@Dominik1999
Copy link
Contributor

Thanks for creating that issue. We, the MS / PFS team, will prepare everything to include this. We would need that temporary solution working until 01.02.2019. Do you think this is possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants