Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport: Not existing global room join is slow #3940

Closed
ulope opened this issue Apr 26, 2019 · 1 comment
Closed

Transport: Not existing global room join is slow #3940

ulope opened this issue Apr 26, 2019 · 1 comment
Labels
Component / Transport Transport related issues

Comments

@ulope
Copy link
Collaborator

ulope commented Apr 26, 2019

Problem Definition

When Raiden tries to join a not yet existing global room it attempts to find this room on all known servers.

Requests with aliases that don't point to the current homeserver are federated.
Due to unknown reasons (possibly a bug in the increasingly outdated synapse version we're using, related #3387) those federation requests return an HTTP status of 500 instead of the correct 404. This leads to the retry mechanism in GMatrixHttpApi:

for delay in self.retry_delay():
try:
with self._semaphore:
return super()._send(method, path, *args, **kwargs)
except (MatrixRequestError, MatrixHttpLibError) as ex:
# from MatrixRequestError, retry only 5xx http errors
if isinstance(ex, MatrixRequestError) and ex.code < 500:
raise

delaying the bubbling up of the exception to the MatrixTransport where it signifies that the next server should be used.

Possible Solutions

  • Possibly an update of the Synapse version will solve the 404/500 discrepancy and nothing is required to be done in Raiden
  • Implement a way to suspend request retry during global room join
@ulope ulope added P2 Component / Transport Transport related issues labels Apr 26, 2019
@rakanalh rakanalh removed the P2 label Oct 28, 2019
@ulope
Copy link
Collaborator Author

ulope commented Nov 19, 2019

This is now obsolete since room creation is happening server side.

See raiden-network/raiden-service-bundle#47

@ulope ulope closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component / Transport Transport related issues
Projects
None yet
Development

No branches or pull requests

2 participants