Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error screen showing when connection to API fails #603

Closed
manuelwedler opened this issue Mar 4, 2021 · 0 comments · Fixed by #613
Closed

No error screen showing when connection to API fails #603

manuelwedler opened this issue Mar 4, 2021 · 0 comments · Fixed by #613
Labels
bug Something isn't working

Comments

@manuelwedler
Copy link
Contributor

Describe the bug

The current version of the WebUI doesn't show the errors screen when it fails to connect to the API. In #573 we introduced a change to the error handling interceptor in order to not handle PFS API errors as client API errors. The problem seems to be this check:

error.url.startsWith(this.raidenConfig.api) &&

It seems like it does not match the URL of the Raiden API.

Steps to reproduce

Close the Raiden client while having the WebUI open in the browser.

Expected behavior

Show the error screen.

System

  • Raiden: v1.1.1.dev445+g35ef6b589
  • WebUI: v1.1.1
  • Environment: development
  • Network: Görli
  • User agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant