Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveSupport::Notifications#unsubscribe #189

Closed
rpbaltazar opened this issue Feb 5, 2022 · 0 comments · Fixed by #190
Closed

Remove ActiveSupport::Notifications#unsubscribe #189

rpbaltazar opened this issue Feb 5, 2022 · 0 comments · Fixed by #190

Comments

@rpbaltazar
Copy link
Contributor

Copied from the Original PR

Hi Rails-on-Services! 👋

I'm a developer on the New Relic Ruby Agent team. I recently discovered that the config.active_record_log option disables all Datastore recording for our newrelic_rpm gem.

The culprit seems to be the line removed in this PR. Calling #unsubscribe on ActiveSupport::Notifications interferes with the strategy many gems use to instrument ActiveRecord's behavior.

My intention behind this PR is to start a conversation about why the #unsubscribe method is called and if we can find another way achieve its goal.

Thanks for your time and for picking up the torch on this great library. 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant