From 99d41667c97aa43a51b586b4303f870d407dc1c1 Mon Sep 17 00:00:00 2001 From: lijunwei Date: Tue, 1 Nov 2022 23:24:17 +0800 Subject: [PATCH] Remove test_order method check in test/helper.rb * currently globalid is depending on 'activesupport >= 5.0', which makes the `ActiveSupport::TestCase.respond_to?(:test_order=)` check redundant * in `activesupport > 4.1.16, < 5.0` , `ActiveSupport::TestCase.test_order` default to `:sorted`, but in 'activesupport >= 5.0', its default is `:random`, so these thress lines of code can be removed --- test/helper.rb | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/helper.rb b/test/helper.rb index a38d752..e93f118 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -9,11 +9,6 @@ require 'json' -if ActiveSupport::TestCase.respond_to?(:test_order=) - # TODO: remove check once ActiveSupport dependency is at least 4.2 - ActiveSupport::TestCase.test_order = :random -end - GlobalID.app = 'bcx' # Default serializers is Marshal, whose format changed 1.9 -> 2.0,