-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack Loader Options Plugin Still Needed? #129
Comments
We shouldn't have anything that's for backwards compatibility in the generated files right now. So a PR to clean that up would be good 👍 |
I could do this. Do we have any way to assign tasks, to avoid duplication of efforts? |
@justin808 I can clean this up in the coming up PR for #109 since it involves same files. |
@justin808 this is fixed now. We can close this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was added here: 1bc83f0
And is here: https://github.com/rails/webpacker/blob/master/lib/install/config/development.js#L20
What are the specific loaders that still require this?
I'd be in favor of having some comments in the webpack JS files for when things like this are added for backward compatibility so that we know when to remove them.
The text was updated successfully, but these errors were encountered: