Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Loader Options Plugin Still Needed? #129

Closed
justin808 opened this issue Feb 27, 2017 · 4 comments
Closed

Webpack Loader Options Plugin Still Needed? #129

justin808 opened this issue Feb 27, 2017 · 4 comments

Comments

@justin808
Copy link
Contributor

It was added here: 1bc83f0

The LoaderOptionsPlugin is unlike other plugins. It exists to help people move from webpack 1 to webpack 2. With webpack 2 the schema for a webpack.config.js became stricter; no longer open for extension by other loaders / plugins. With webpack 2 the intention is that you pass options directly to loaders / plugins. i.e. options are not global / shared.

And is here: https://github.com/rails/webpacker/blob/master/lib/install/config/development.js#L20

What are the specific loaders that still require this?

I'd be in favor of having some comments in the webpack JS files for when things like this are added for backward compatibility so that we know when to remove them.

@dhh
Copy link
Member

dhh commented Mar 1, 2017

We shouldn't have anything that's for backwards compatibility in the generated files right now. So a PR to clean that up would be good 👍

@justin808
Copy link
Contributor Author

I could do this. Do we have any way to assign tasks, to avoid duplication of efforts?

@gauravtiwari
Copy link
Member

@justin808 I can clean this up in the coming up PR for #109 since it involves same files.

@gauravtiwari
Copy link
Member

@justin808 this is fixed now. We can close this one :)

@dhh dhh closed this as completed Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants