Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add erb extensions to paths.yml? #262

Closed
naps62 opened this issue Apr 17, 2017 · 3 comments
Closed

add erb extensions to paths.yml? #262

naps62 opened this issue Apr 17, 2017 · 3 comments

Comments

@naps62
Copy link

naps62 commented Apr 17, 2017

I just spent a considerable amount of time debugging why my application wasn't working once I tried to add .erb components to my webpacker setup

since I'm not that knowledgeable about webpack, I thought this was a loader issue, but it turns out it worked after changing the imports to have an explicit extension:

`import Search from './search.jsx.erb'; // this was not working without the extensions

After some more fiddling, I found that adding .jsx.erb to the paths.yml file, this is no longer necessary

So my question is, should we add things like .jsx.erb and .js.erb to that file by default? Did I do something wrong, and should those not be necessary?

@gauravtiwari
Copy link
Member

Probably need to add the extensions config part in documentation so it's more clear.

@a3ammar
Copy link

a3ammar commented May 14, 2017

I just went through the same process as @naps62. Shouldn't the generated path.yml include these extension by default?

Also how can I help? I see there's PR #372 to overhaul the documentation so I'm not sure about the meaning of the help wanted label.

@gauravtiwari
Copy link
Member

Fixed in #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants