Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1755
Figma link (if any):
What changed (plus any additional context for devs)
assetToSellWithPrice
was incorrectly usingassetToBuy?.uniqueId
instead ofassetToSell?.uniqueId
. We only use this data when we create the object forparsedAssetToSell
, which is returned as theassetToSell
in our swaps flow.Using
assetToBuy?.uniqueId
inassetToSellWithPrice
caused us to check the native token price on the output chain instead of the input chain. This would only be noticeable for cross-chain swaps between chains that don't share a native token price.Screen recordings / screenshots
Screen.Recording.2025-02-04.at.4.09.47.PM.mov
What to test