Prevent Google OAuth prompt on app launch #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
added
release
brunobar79
reviewed
Jan 4, 2025
walmat
commented
Jan 6, 2025
walmat
changed the title
checkPermissions flag on account check
ibrahimtaveras00
approved these changes
Jan 6, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2239
What changed (plus any additional context for devs)
If the user had pending OAuth permissions, our backups sync would spam them due to the nature of how we retry on failures. We now prevent the prompt if they don't have permissions enabled, and if it does prompt we detect the cancellation and only prompt once instead of falling through the
try...catchblock.Screen recordings / screenshots
will try to capture one soon
What to test
https://rainbowhaus.slack.com/archives/C02C2FVC6N6/p1735921689825149?thread_ts=1735501963.465679&cid=C02C2FVC6N6