[bug] Custom chain name is overriden by default chain config

[ilzheev]

Is there an existing issue for this?

• I have searched the existing issues

RainbowKit Version

2.1.0

wagmi Version

2.9.0

Current Behavior

Init BNB Chain with custom chain config

  {
    id: 56,
    name: 'BNB Chain',
    iconBackground: '#fff',
    nativeCurrency: {
      decimals: 18,
      name: 'BNB Chain',
      symbol: 'BNB',
    },
    rpcUrls: {
      public: { http: ['https://rpc.ankr.com/bsc'] },
      default: { http: ['https://rpc.ankr.com/bsc'] },
    },
    blockExplorers: {
      default: { name: 'BscScan', url: 'https://bscscan.com' },
    }
  }

Chain with this config is displayed in Rainbowkit, but the name is overriden to BSC:

Expected Behavior

Chain name should be as set in custom config – BNB Chain

Steps To Reproduce

• Init custom chain with following config:

  {
    id: 56,
    name: 'BNB Chain',
    iconBackground: '#fff',
    nativeCurrency: {
      decimals: 18,
      name: 'BNB Chain',
      symbol: 'BNB',
    },
    rpcUrls: {
      public: { http: ['https://rpc.ankr.com/bsc'] },
      default: { http: ['https://rpc.ankr.com/bsc'] },
    },
    blockExplorers: {
      default: { name: 'BscScan', url: 'https://bscscan.com' },
    }
  }

• do NOT include standard BSC chain config in Rainbowkit init

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

[DanielSinclair]

@ilzheev This is currently expected. We use colloquial names (i.e. Arbitrum vs Arbitrum One) for a handful of chains. Do you think BNB is incorrect in this context?

[ilzheev]

@DanielSinclair When we initially deployed, BNB Chain team asked us to rename BSC / Binance Smart Chain to BNB Chain in our UI – I assume they don't want to be associated with Binance anymore and try to stick to BNB Chain name.

If the requirement is to use colloquial names only, I am not sure if BNB is better than BSC.

Ideal solution, in my opinion, is to allow developers to override name parameter using custom chains – especially considering that iconBackground & iconUrl are allowed to be overridden using custom chain config. Not sure why name override does not work in the same config struct.

[jTerraBit]

@DanielSinclair @ilzheev We are also experiencing this issue and need to set the name to BNB Chain