Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styles command not working on Windows. #2

Closed
ackzell opened this issue Mar 30, 2022 · 3 comments
Closed

Remove styles command not working on Windows. #2

ackzell opened this issue Mar 30, 2022 · 3 comments

Comments

@ackzell
Copy link

ackzell commented Mar 30, 2022

Hi,

Thanks for sharing your work @rakibdev !

Unfortunately I was not able to use your "remove styles" command and all my themes were stuck with the rounded styled tabs and buttons with the ripple effect on the clickable items.

I had to go into my Windows installation folder for VSCode and manually remove the code this extension adds to:

 C:\Users\{userName}\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\code\electron-browser\workbench\workbench.html 

I don't know if this is a regular practice for extensions to update those files but being honest I don't feel right with the approach.

In any case this is the only way I was able to solve it and VSCode still complained that my installation was corrupted.

@RicardoMoraisPOR
Copy link

+1

@rakibdev
Copy link
Owner

@ackzell
Hi, I checked in both Windows, Ubuntu. Unable to reproduce this issue. Error logs should show in Visual Studio Code DevTools. Can I get those?

I don't feel right with the approach

This is only way I find. This method used by popular "Custom CSS and JS loader" and "Synthwave" extension. Therefore, kept it optional. I will add in README "This modifies installation workbench.html file. And workbench.html resets after each update."

still complained that my installation was corrupted

Checksums in product.json also have to be updated using "Fix VSCode Checksums" extension if manually editing workbench.html

@ackzell
Copy link
Author

ackzell commented Jul 13, 2022

Thanks for getting back at me @rakibdev

I uninstalled the theme and haven't added it back since.

Adding the note to the README seems like a good move. Thanks for the links!

@ackzell ackzell closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants