Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check flags in point compressions #19

Open
ralexstokes opened this issue Jun 24, 2020 · 0 comments
Open

Check flags in point compressions #19

ralexstokes opened this issue Jun 24, 2020 · 0 comments

Comments

@ralexstokes
Copy link
Owner

Consider checking the flag bits in the {public key, signature} compressed representations as additional sanity checks.

From @benjaminion:

On the flags, my concern is about tooling that generates them incorrectly due to broken serialisation. It may be a miniscule risk, but I've seen crazier things. It would be ideal if the proxy would pass data if and only if it is all correct. Checking the flag against the provided y-coord is fairly simple: you just need a greater-than operation for Fps. It can be done just before the flags are masked away. To be clear for those not familiar with this: if the flag is wrong, the compressed point will deserialise to a different point than intended and the signature will fail, even if it passes the verification in the proxy contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant