Fix bitbucket test

As @ryneeverett pointed out, `bitbucket.login` is a required setting so
we add it to the test fixture.

In addition, this commit update the bicbucket service to validate that a
`bitbucket.login` is present in the configuration.

bugwarrior/services/bitbucket.py

@@ -66,14 +66,13 @@ def __init__(self, *args, **kw):
         super(BitbucketService, self).__init__(*args, **kw)
 
         self.auth = None
-        if self.config_get_default('login'):
-            login = self.config_get('login')
-            password = self.config_get_password(
-                'password',
-                self.get_keyring_service(self.config, self.target),
-                login)
+        login = self.config_get('login')
+        password = self.config_get_password(
+            'password',
+            self.get_keyring_service(self.config, self.target),
+            login)
 
-            self.auth = (login, password)
+        self.auth = (login, password)
 
         self.exclude_repos = []
         if self.config_get_default('exclude_repos', None):
@@ -136,6 +135,8 @@ def get_data(self, url, **kwargs):
     def validate_config(cls, config, target):
         if not config.has_option(target, 'bitbucket.username'):
             die("[%s] has no 'username'" % target)
+        if not config.has_option(target, 'bitbucket.login'):
+            die("[%s] has no 'login'" % target)
 
         IssueService.validate_config(config, target)
 

tests/test_bitbucket.py

@@ -6,6 +6,7 @@
 class TestBitbucketIssue(ServiceTest):
     SERVICE_CONFIG = {
         'bitbucket.login': 'something',
+        'bitbucket.username': 'somename',
         'bitbucket.password': 'something else',
     }