Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Deployment profile registry key types get auto corrected #4218

Closed
gunamata opened this issue Mar 17, 2023 · 5 comments
Closed

Windows Deployment profile registry key types get auto corrected #4218

gunamata opened this issue Mar 17, 2023 · 5 comments
Assignees
Labels
area/deployment Deployment profiles kind/bug Something isn't working platform/windows triage/duplicate This issue or pull request already exists
Milestone

Comments

@gunamata
Copy link
Contributor

The deployment profile keys get auto corrected which is not correct. For example, the code at present seems to be okay if REG_SZ is used instead of REG_MULTI_SZ etc.

@gunamata gunamata added kind/bug Something isn't working platform/windows labels Mar 17, 2023
@ericpromislow
Copy link
Contributor

I don't understand where the auto-correcting is taking place. It looks like there's a missing attachment in this report.

@jandubois
Copy link
Member

I think Guna means that incorrect types don't throw an exception.

E.g. using REG_SZ instead of REG_MULTI_SZ will be auto-converted into an array with a single entry instead of throwing a type-mismatch error.

But also a REG_DWORD would be accepted as a string, but I think it will just take the DWORD value as the codepoint for a single character instead of converting the DWORD to a string representation of the number.

Instead of hoping that these auto-conversions yield the expected result, we should treat all of them as errors.

@ericpromislow
Copy link
Contributor

I started a branch to work on this on Friday -- I'll see how it's working now

@gaktive gaktive added this to the 1.9 milestone Mar 20, 2023
@ericpromislow
Copy link
Contributor

Once PR #4251 gets merged I'll convert type mismatches from a log statement to a fatal exception that appears in a dialog box. That PR is large enough.

@ericpromislow
Copy link
Contributor

Duplicate of #4159

@ericpromislow ericpromislow marked this as a duplicate of #4159 May 8, 2023
@jandubois jandubois added the triage/duplicate This issue or pull request already exists label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment Deployment profiles kind/bug Something isn't working platform/windows triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants