Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No proxy list doesn't respond correctly to locked preferences #5468

Closed
mook-as opened this issue Sep 5, 2023 · 2 comments · Fixed by #5617
Closed

No proxy list doesn't respond correctly to locked preferences #5468

mook-as opened this issue Sep 5, 2023 · 2 comments · Fixed by #5617
Assignees
Milestone

Comments

@mook-as
Copy link
Contributor

mook-as commented Sep 5, 2023

Actual Behavior

When the no proxy host name list is locked (via deployment policies), it's not correctly locked in the UI; it's still possible to modify the multi-line text area holding the list (but it's not possible to actually submit the changes).

screenshot showing the locked no proxy list being edited

Steps to Reproduce

  1. Factory reset (this creates a default no-proxy list).
  2. Start Rancher Desktop.
  3. Run rdctl create-profile --from-settings --output reg --type locked --hive hkcu | Out-File -Encoding utf8 .\settings.reg to generate a deployment profile.
  4. Double click the newly generated settings.reg and import it into the registry.
  5. Start Rancher Desktop
  6. Go to Preferences → WSL → Proxy
  7. Try to edit the no proxy list.

Result

It is possible to edit the list; there is no indication that the preference is locked.

Expected Behavior

The list should be disabled (as in, the user should not be able to edit it).

Additional Information

This will probably be obsoleted by #5344

Rancher Desktop Version

1.10-RC1 (0dd5a25)

Rancher Desktop K8s Version

N/A

Which container engine are you using?

containerd (nerdctl)

What operating system are you using?

Windows

Operating System / Build Version

Windows 11 Pro 22H2 (Build 22621.2134)

What CPU architecture are you using?

x64

Linux only: what package format did you use to install Rancher Desktop?

None

Windows User Only

None (fresh VM).

@s0nea
Copy link

s0nea commented Sep 6, 2023

Indeed. There is no way to lock the textarea. Would is be possible to fix it as part of #5344 or will the fix be needed earlier?

@gaktive gaktive added the triage/next-candidate Discuss if it should be moved to "Next" milestone label Sep 6, 2023
@jandubois
Copy link
Member

Would is be possible to fix it as part of #5344 or will the fix be needed earlier?

It should be fixed as part of #5344. This is not a critical issue as validation still prevents you from applying the setting after you changed it from its locked value. This is not good UX, but does not violate the promise of the locked profile.

@gunamata gunamata removed the triage/next-candidate Discuss if it should be moved to "Next" milestone label Sep 11, 2023
@gunamata gunamata added this to the 1.11 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants