Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SURE-9104] Improve Fleet Performance #12424

Closed
richard-cox opened this issue Oct 30, 2024 · 5 comments · Fixed by #12521
Closed

[SURE-9104] Improve Fleet Performance #12424

richard-cox opened this issue Oct 30, 2024 · 5 comments · Fixed by #12521
Assignees
Labels
area/fleet area/performance kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Oct 30, 2024

Internal reference SURE-9104

Setup

  • Rancher version: 2.9

Contributes to SURE-9104

Describe the bug

Improve or remove fleet git repo clusterResourceStatus and resourcesStatuses getters

  • The performance of clusterResourceStatus and specifically resourcesStatuses is horrible
    • Compounded by being called a LOT given bundledeployment churn
  • We need a short term fix before understanding final information requirements of fleet
    • Could involve fleet providing summary of states as requierd
    • Could involve making some very low bar fixes to functions
    • Could involve removing the need to show data

Remove dependnecy on bundledeployment resource type

  • this can be HUGE, taking many seconds to fetch and then provide churn over websocket
  • need to confirm where this data is used and either remove the need for it or receive from Fleet directly

Additional context
Reference chain

gitRepo clusterResourceStatus
--> shell/components/formatter/FleetSummaryGraph.vue component computed summary. find specific cluster --> status.resoureCounts
--> FLEET_SUMMARY header
--> Fleet Cluster List View (Resources Column)
--> shell/components/fleet/FleetRepos.vue cluster (in not cluster mode) list
--> Fleet Git Repo List (actual list)
--> Fleet cluster Group List View (Resources Column)
--> shell/components/formatter/FleetClusterSummaryGraph.vue wrapper
--> shell/components/fleet/FleetRepos.vue (in cluster mode)
--> Fleet Cluster Detail View (git repo list 'Resources' column)
--> shell/components/fleet/FleetRepos.vue (in cluster mode)
--> find current cluster --> cluster.status?.displayStatus
--> Fleet Cluster Detail View (git repo list)

gitRepo resourcesStatuses
--> gitRepo clusterResourceStatus
--> shell/components/fleet/FleetResources.vue
--> Fleet Git Repo Detail View (resources table)

trying to summarise ...

  • Fleet Cluster List View (Resources Column)
  • Fleet Git Repo List (State column)
  • Fleet Git Repo List (Resources column)
  • Fleet ClusterGroup List View (Resources Column)
  • Fleet Cluster Detail View (top section, large pills)
  • resourcesStatuses is only used specifically in the Fleet Git Repo Detail View (resources table)
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

I'll defer on filing a back port issue for now until @richard-cox determines the approach.

@richard-cox
Copy link
Member Author

/backport v2.10.1

@richard-cox
Copy link
Member Author

/backport v2.9.5

@richard-cox
Copy link
Member Author

@ QA please reach out to me for areas to test / scale

@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 21, 2024
@IsaSih IsaSih self-assigned this Nov 29, 2024
@IsaSih
Copy link
Contributor

IsaSih commented Nov 29, 2024

Validated in v2.9-023781e52103c45a9bbdf3cb47d60b9336321daa-head and v2.10-0f28018201f044edebee948e7644fd45836d24c7-head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet area/performance kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants