Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_args_array Field #348

Open
HarrisonWAffel opened this issue Jul 11, 2022 · 4 comments
Open

Add extra_args_array Field #348

HarrisonWAffel opened this issue Jul 11, 2022 · 4 comments

Comments

@HarrisonWAffel
Copy link
Contributor

HarrisonWAffel commented Jul 11, 2022

Relates to : rancher/rke#2908 rancher/rancher#25500
Two new fields were added to RKE, ExtraArgsArray and WindowsExtraArgsArray. These fields allow users to specify an extraArg multiple times with different values. The provider now needs to be updated to support these two new fields.

@snasovich
Copy link
Collaborator

@HarrisonWAffel , since it's for TF and we have a bit more time to implement TF changes, assigning 2.6.7 milestone to it. If it's not done soon, we can bump it to 2.7.0.

@Josh-Diamond
Copy link

Test Plan - Initial Draft

Scenario 1:

  • Test Case: Using tf-rke-provider, spin up cluster w/ extra_args_array containing multiple extra_args (at least 2), with each extra_arg defining at least 2 values, for each service available: [kubeapi, scheduler, etcd, etc]
  • Expected Result: terraform plan should accurately represent requested infrastructure; terraform apply should successfully provision cluster

Scenario 2:

  • Test Case: Using tf-rke-provider, spin up cluster w/ win_extra_args_array containing multiple extra_args (at least 2), with each extra_arg defining at least 2 values, for each service available: [kubeapi, scheduler, etcd, etc]
  • Expected Result: terraform plan should accurately represent requested infrastructure; terraform apply should successfully provision cluster

@hchen-tubi
Copy link

hchen-tubi commented Aug 24, 2023

Any progress or further plan on this? We are waiting for it and it'd be nice to have this feature available in the terraform provider

@a-blender
Copy link
Contributor

a-blender commented Nov 16, 2023

Discussed this issue and PR #427 with @HarrisonWAffel last week.

There's a problem with a tf plan/apply always showing changes because the extra_args_array field is a map and maps are not ordered in Go. We could not find a workable solution to maintain the ordering that a user originally sets for extra args in the TF configuration. This is not possible because with sdk v1, there is no way to persist a map order in the TF state so when the configuration is expanded, then flattened again to read the upstream infra we have no way of knowing how the array was originally ordered.

However, this issue appears to be fixed in the migration to sdk v2 due to updates in how Terraform handles the concept of state.

The PR needs to be updated but @HarrisonWAffel is out this week so pushing this issue to release v1.4.4 so v1.4.3 can be released this week.

@a-blender a-blender modified the milestones: v1.4.3, v1.4.4 Nov 16, 2023
@Jono-SUSE-Rancher Jono-SUSE-Rancher modified the milestones: v1.4.4, v1.4.5 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants