You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In all RAPIDS repos, replace cmake/thirdparty/x.cmake files that only contain include and rapids_cpm_x with a single call to rapids_cpm_include and inlined rapids_cpm_x, like so:
Prompted by a comment from @vyasr rapidsai/rmm#1558 (comment)
We should eliminate
cmake/thirdparty/x.cmake
files that have just these two repeated lines in them:As Vyas pointed out, these files are trivial and repetitive, and lead to more code to maintain than just inlining the
include
andrapids_cpm_x
call.I propose two things:
This would expand to
cmake/thirdparty/x.cmake
files that only containinclude
andrapids_cpm_x
with a single call torapids_cpm_include
and inlinedrapids_cpm_x
, like so:Note that more complex
cmake/thirdparty/x.cmake
files should be kept. For example: https://github.com/rapidsai/rmm/blob/branch-24.06/cmake/thirdparty/get_spdlog.cmakeThe text was updated successfully, but these errors were encountered: