You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
Propose to match segmented_shift behavior in returning an all-null column if fill_value is unspecified or return a column filled with fill_value if otherwise.
Environment overview (please complete the following information)
Environment location: [compose]
Method of cuDF install: [compose]
The text was updated successfully, but these errors were encountered:
Closes#10314
Fixes logic to handle `abs(offset) > input.size()` when passed to `cudf::shift`. As mentioned in #10314 this was causing an unexpected exception:
```
C++ exception with description "parallel_for failed: cudaErrorInvalidConfiguration: invalid configuration argument" thrown in the test body.
```
The behavior now fills the entire output column with the input scalar value. If the scalar is null, then the column is filled with null entries. The logic added here did not require changing or adding any new kernel functions. Additional gtests were added to `shift_tests.cpp` as well.
Authors:
- David Wendt (https://github.com/davidwendt)
Approvers:
- GALI PREM SAGAR (https://github.com/galipremsagar)
- MithunR (https://github.com/mythrocks)
- Yunsong Wang (https://github.com/PointKernel)
URL: #10414
Describe the bug
When
offset
is greater than the size of the column, libcudf will fail with not user-friendly error messages.Steps/Code to reproduce bug
Expected behavior
Propose to match
segmented_shift
behavior in returning an all-null column iffill_value
is unspecified or return a column filled withfill_value
if otherwise.Environment overview (please complete the following information)
The text was updated successfully, but these errors were encountered: