Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cudf::distinct implementation missed stream parameter when calling to key_map.contains #10909

Closed
ttnghia opened this issue May 19, 2022 · 0 comments · Fixed by #10916
Closed

[BUG] cudf::distinct implementation missed stream parameter when calling to key_map.contains #10909

ttnghia opened this issue May 19, 2022 · 0 comments · Fixed by #10916
Assignees
@PointKernel
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@ttnghia
Copy link
Contributor

ttnghia commented May 19, 2022

This is a small issue. As the title says: cudf::distinct implementation (in file distinct.cu missed stream parameter when calling to key_map.contains. We should correct that whenever possible.
@ttnghia ttnghia added bug Something isn't working Needs Triage Need team to review and classify labels May 19, 2022
@PointKernel PointKernel added the libcudf Affects libcudf (C++/CUDA) code. label May 20, 2022
@PointKernel PointKernel self-assigned this May 20, 2022
@PointKernel PointKernel mentioned this issue May 20, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue May 27, 2022
@PointKernel
Improve distinct by using cuco::static_map::retrieve_all (#10916)
6eca42f 
Closes #10909

This PR was intended to fix a bug in the `distinct` implementation where the stream parameter was not passed when invoking `static_map::contains`. During the work, @ttnghia Pointed out that the `contains` + `thrust::copy_if` logic can be simplified by using `static_map::retrieve_all`. Finally, the PR fetches a newer version of `cuco` to utilize `retrieve_all` and fixes a bug in unit tests where results should be sorted before comparison.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #10916
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PointKernel PointKernel

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve distinct by using cuco::static_map::retrieve_all PointKernel/cudf
3 participants
@bdice @ttnghia @PointKernel