Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Unify lists/drop_list_duplicates.hpp header into lists/stream_compaction.hpp #11034

Closed
ttnghia opened this issue Jun 2, 2022 · 1 comment · Fixed by #11236
Closed

[FEA] Unify lists/drop_list_duplicates.hpp header into lists/stream_compaction.hpp #11034

ttnghia opened this issue Jun 2, 2022 · 1 comment · Fixed by #11236
Labels
libcudf Affects libcudf (C++/CUDA) code. proposal Change current process or code

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Jun 2, 2022

Currently, lists::drop_list_duplicates API is declared in a separate header. The API should belong to the stream_compaction family, so we can move the declaration into the lists/stream_compaction.hpp header.
@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify labels Jun 2, 2022
@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 2, 2022

However, there is another approach for re-locating this API: Moving it into set_operations.hpp, because this is equivalent to array_distinct in other framework which stays together with other array_ ops.

@GregoryKimball GregoryKimball added proposal Change current process or code code quality libcudf Affects libcudf (C++/CUDA) code. and removed feature request New feature or request Needs Triage Need team to review and classify labels Jun 29, 2022
This was referenced Jul 8, 2022
Closed
Merged
@ttnghia ttnghia linked a pull request Jul 14, 2022 that will close this issue
Remove lists::drop_list_duplicates #11236
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 22, 2022
@ttnghia
Remove lists::drop_list_duplicates (#11236)
a541ffb 
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work.

Closes #11114, #11093, #11053, #11034, and closes #9257.

Depends on:
 * #11228
 * #11149
 * #11234
 * #11233

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Robert Maynard (https://github.com/robertmaynard)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

URL: #11236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libcudf Affects libcudf (C++/CUDA) code. proposal Change current process or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove lists::drop_list_duplicates ttnghia/cudf
2 participants
@ttnghia @GregoryKimball