Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support null_equality parameter in cudf::contains #11041

Closed
ttnghia opened this issue Jun 3, 2022 · 1 comment
Closed

[FEA] Support null_equality parameter in cudf::contains #11041

ttnghia opened this issue Jun 3, 2022 · 1 comment
Labels
feature request New feature or request

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Jun 3, 2022

The current implementation of cudf::contains(column_view const& haystack, column_view const& needles) doesn't support null_equality option. As such, any null row in the input needles column will result in a null in the corresponding output row. If we want to actually check for contains/existence for null rows from needles, we have to work around somehow.

It is better to support null_equality so we call specify whether a null row from needles will result in a null output row, or will be actually checked for existence in haystack. This is necessary to support calling cudf::contains in semi_anti_join implementation (#11037).

@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify labels Jun 3, 2022
@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 3, 2022

Just realize that semi_anti_join can just work around this during building the gather map. So close this.

@ttnghia ttnghia closed this as completed Jun 3, 2022
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants