Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] mixed left_semi and left_anti produce incorrect results in 24.10 #16852

Closed
abellina opened this issue Sep 19, 2024 · 1 comment
Closed

[BUG] mixed left_semi and left_anti produce incorrect results in 24.10 #16852

abellina opened this issue Sep 19, 2024 · 1 comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@abellina
Copy link
Contributor

I have been able to verify that a regression we are seeing in spark NVIDIA/spark-rapids#11485 is fixed after I revert #16230.

The symptom is that we are not producing rows that the CPU produces (and that the GPU used to produce before this change).

I'll try to come up with a C++ repro.
@abellina abellina added the bug Something isn't working label Sep 19, 2024
@abellina abellina added this to libcudf Sep 19, 2024
@abellina abellina added libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS labels Sep 19, 2024
@mhaseeb123 mhaseeb123 mentioned this issue Sep 19, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 20, 2024
@mhaseeb123
Revert "Refactor mixed_semi_join using cuco::static_set" (#16855)
dc57c1b 
Reverting #16230 as this PR leads to #16852.

Authors:
  - Muhammad Haseeb (https://github.com/mhaseeb123)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Yunsong Wang (https://github.com/PointKernel)
  - Bradley Dice (https://github.com/bdice)

URL: #16855
@abellina
Copy link
Contributor Author

The change has gone into 24.12 with #16859. I am closing this issue as it doesn't relate to 24.10 anymore. If we have issues in 24.12 we can raise another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
libcudf
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abellina