-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use column_views instead of column_device_views in binary operations. #10780
Use column_views instead of column_device_views in binary operations. #10780
Conversation
This reverts commit 33173e4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits, otherwise looks good and matches functionality implemented and already reviewed in #9452
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10780 +/- ##
================================================
+ Coverage 86.40% 86.43% +0.02%
================================================
Files 143 143
Lines 22448 22448
================================================
+ Hits 19396 19402 +6
+ Misses 3052 3046 -6
Continue to review full report at Codecov.
|
@gpucibot merge |
rerun tests |
This PR changes the internal APIs used for binary operations to use
column_view
objects instead ofcolumn_device_view
objects. This change is needed for the eventual support of structs in binary operations. See also: PR #9452.