Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade to arrow-8 #10816

Merged
merged 6 commits into from
Jun 15, 2022
Merged

[REVIEW] Upgrade to arrow-8 #10816

merged 6 commits into from
Jun 15, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR upgrades arrow to 8.

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2022
@galipremsagar galipremsagar self-assigned this May 9, 2022
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels May 9, 2022
@galipremsagar galipremsagar changed the base branch from branch-22.06 to branch-22.08 June 2, 2022 14:14
@jakirkham
Copy link
Member

rerun tests

2 similar comments
@jakirkham
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

Looks like packages are now installed 🎉

However there are segfaults in CI. Particularly after ToArrowTest.NestedList (same on all CI jobs that fail). May need a deeper dive into why that is happening

@github-actions github-actions bot added the gpuCI label Jun 3, 2022
@galipremsagar
Copy link
Contributor Author

galipremsagar commented Jun 3, 2022 •
edited
Loading

Looks like packages are now installed 🎉

However there are segfaults in CI. Particularly after ToArrowTest.NestedList (same on all CI jobs that fail). May need a deeper dive into why that is happening

Yup, that's expected with some stale arrow version lying around. This commit is needed to get past that error: 8a474c8

EDIT: Looking into the segfault.
EDIT: Resolved.

@jakirkham
Copy link
Member

Thanks Prem! 🙏

So was it just an old version or was there more going on with the segfault?

@galipremsagar
Copy link
Contributor Author

Thanks Prem! 🙏

So was it just an old version or was there more going on with the segfault?

Yea for some reason, if an env has an older version of arrow and conda upgrades it, we see that kind of segfaults. But when we force remove old versions before installing a new version or create a new env with new version of arrow we never run into such kind of segfaults.

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@a00cca6). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #10816   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22738           
  Branches                ?        0           
===============================================
  Hits                    ?    19632           
  Misses                  ?     3106           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00cca6...cf45f7c. Read the comment docs.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team DO NOT MERGE Hold off on merging; see PR for details and removed 2 - In Progress Currently a work in progress labels Jun 3, 2022
@galipremsagar galipremsagar changed the title [WIP] Upgrade to arrow 8 [REVIEW] Upgrade to arrow-8 Jun 3, 2022
@galipremsagar galipremsagar marked this pull request as ready for review June 3, 2022 16:20
@galipremsagar galipremsagar requested review from a team as code owners June 3, 2022 16:20
@galipremsagar galipremsagar mentioned this pull request Jun 3, 2022
Merged
@ajschmidt8 ajschmidt8 added DO NOT MERGE Hold off on merging; see PR for details and removed DO NOT MERGE Hold off on merging; see PR for details labels Jun 8, 2022
galipremsagar
galipremsagar commented Jun 8, 2022
View reviewed changes
@github-actions github-actions bot removed the gpuCI label Jun 8, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team DO NOT MERGE Hold off on merging; see PR for details 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jun 8, 2022
@jakirkham
Copy link
Member

Do we know what is going on with the CI failure here?

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 15, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 77ca025 into rapidsai:branch-22.08 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @jakirkham @harrism @ajschmidt8