Make cudf::test::expect_columns_equal() to fail when comparing unsanitary lists. #10880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbaranec
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10880 +/- ##
================================================
+ Coverage 86.29% 86.33% +0.03%
================================================
Files 144 144
Lines 22656 22665 +9
================================================
+ Hits 19551 19567 +16
+ Misses 3105 3098 -7
Continue to review full report at Codecov.
|
vuule
reviewed
May 18, 2022
ttnghia
reviewed
May 18, 2022
vuule
approved these changes
May 19, 2022
harrism
approved these changes
May 19, 2022
ttnghia
approved these changes
May 19, 2022
ttnghia
approved these changes
May 19, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 23, 2022
Addresses: #10800 Previously, `concatenate_rows()` only handled lists one level deep. This PR adds support for arbitrary nesting. <s>This PR is dependent on : #10880 so some of the files currently showing up on the diff are unrelated to the `concatenate_rows()` change.</s> Authors: - https://github.com/nvdbaranec Approvers: - Robert (Bobby) Evans (https://github.com/revans2) - Vukasin Milovanovic (https://github.com/vuule) - Nghia Truong (https://github.com/ttnghia) URL: #10890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10855
Unsanitary lists (those with null rows that actually have backing underlying data) should not compare as equal to sanitized lists, but should compare as equivalent. Only one test in cudf was affected by this change, which I've opened a second issue for:
#10856
This PR also adds a utility function to
cudf::test::lists_column_wrapper,static lists_column_wrapper<T> make_one_empty_row_column(bool valid = true)Due to the way initializer lists and nested class initialization work, it was impossible to create a list column with 1 row that was empty, so I added this explicit function to handle the edge case.