Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doxygen warnings in ast/, rolling, tdigest/, wrappers/, dictionary/ headers #10921

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Fix doxygen warnings in ast/, rolling, tdigest/, wrappers/, dictionary/ headers #10921

merged 5 commits into from
Jun 1, 2022

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented May 22, 2022 •
edited
Loading

Fixes parts of #9373
added missing documentation to fix doxygen warnings in multiple files
ast/, rolling, tdigest/, wrappers, dictionary/ headers

fixes 82 warnings.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels May 22, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 22, 2022 12:25
@karthikeyann karthikeyann self-assigned this May 22, 2022
@karthikeyann karthikeyann changed the title add missing doc in ast/, rolling, tdigest/, wrappers, dictionary/ add missing doc in ast/, rolling, tdigest/, wrappers, dictionary/ headers May 22, 2022
@karthikeyann karthikeyann changed the title add missing doc in ast/, rolling, tdigest/, wrappers, dictionary/ headers fix doxygen warnings in ast/, rolling, tdigest/, wrappers, dictionary/ headers May 22, 2022
@karthikeyann karthikeyann changed the title fix doxygen warnings in ast/, rolling, tdigest/, wrappers, dictionary/ headers fix doxygen warnings in ast/, rolling, tdigest/, wrappers/, dictionary/ headers May 22, 2022
@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@9e4fc74). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #10921   +/-   ##
===============================================
  Coverage                ?   86.32%           
===============================================
  Files                   ?      144           
  Lines                   ?    22696           
  Branches                ?        0           
===============================================
  Hits                    ?    19593           
  Misses                  ?     3103           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4fc74...b64b0a9. Read the comment docs.

@karthikeyann karthikeyann changed the title fix doxygen warnings in ast/, rolling, tdigest/, wrappers/, dictionary/ headers Fix doxygen warnings in ast/, rolling, tdigest/, wrappers/, dictionary/ headers May 25, 2022
codereport
codereport approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

vyasr
vyasr requested changes May 25, 2022
View reviewed changes
@karthikeyann @vyasr
Apply suggestions from code review
b64b0a9 
Co-authored-by: Vyas Ramasubramani <[email protected]>
@karthikeyann karthikeyann requested a review from vyasr May 28, 2022 00:37
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0e2e79d into rapidsai:branch-22.08 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@codereport codereport codereport approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @vyasr @codereport