Fix Doxygen warnings in strings / header files #10937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #10937 +/- ##
===============================================
Coverage ? 86.32%
===============================================
Files ? 144
Lines ? 22696
Branches ? 0
===============================================
Hits ? 19593
Misses ? 3103
Partials ? 0 Continue to review full report at Codecov.
|
davidwendt
requested changes
May 24, 2022
codereport
changed the title
davidwendt
requested changes
May 24, 2022
There was a problem hiding this comment.
Looks like the global change to remove periods from @param made some mistakes. I'm not sure this is worth doing in the PR since this does not effect the warnings. My previous comments were just trying to follow conventions for newer comments and not necessarily requiring a global change to existing documentation.
davidwendt
requested changes
May 25, 2022
Co-authored-by: David Wendt <[email protected]>
davidwendt
requested changes
May 31, 2022
Co-authored-by: David Wendt <[email protected]>
davidwendt
reviewed
Jun 1, 2022
This reverts commit 771cd46.
davidwendt
approved these changes
Jun 1, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parts of #9373
added missing documentation to fix doxygen warnings in multiple files
ignored docs for
cudf::string_view::const_iteratorfixes 78 warnings.