-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing fields as nulls in get_json_object() #10970
Handle missing fields as nulls in get_json_object() #10970
Conversation
…rikarVanavasam/cudf into get_json_object_missing_fields
Can one of the admins verify this patch? |
okay to test |
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #10970 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22738
Branches ? 0
===============================================
Hits ? 19632
Misses ? 3106
Partials ? 0 Continue to review full report at Codecov.
|
@mlahir1 Do you guys have some time to try this out and see if it solves your issue? |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't see any tests for set_missing_fields_as_nulls = false
.
|
I think so. We don't know, and are not guanteed, if the existing tests have that covered or not. |
Agreeing with @ttnghia's assessment. I meant to post this as well: It would be good to test |
…rikarVanavasam/cudf into get_json_object_missing_fields
Co-authored-by: Nghia Truong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the review comments. LGTM.
rerun tests |
@gpucibot merge |
1 similar comment
@gpucibot merge |
Thank you very much for the solving this. Sure, i belv this is merged in 22.08 nightly. i will test this sometime this week and check of this solves our issue. |
@SrikarVanavasam , I could find any api changes on python side. Are the missing automatically assigned as Nulls or do i need to pass in some flag in the python API side. |
Hi @mlahir1 . Yeah, sorry we missed this. We'll get a PR up with it soon. |
Addresses: #10196
Previously,
get_json_object()
ignored fields in a JsonPath expression that are missing in the json string. This PR adds the option to return these missing fields as null instead.