Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing #pragma once to header files #11004

Merged
merged 3 commits into from
May 30, 2022
Merged

Add missing #pragma once to header files #11004

merged 3 commits into from
May 30, 2022

Conversation

karthikeyann
Copy link
Contributor

This PR adds the missing #pragma once in few header files in libcudf.
minor include cleanup "" to <>

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 28, 2022 11:43
@karthikeyann karthikeyann self-assigned this May 28, 2022
@karthikeyann karthikeyann changed the title add missing #pragma once to header files Add missing #pragma once to header files May 28, 2022
@codecov
Copy link

codecov bot commented May 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@6025f2b). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11004   +/-   ##
===============================================
  Coverage                ?   86.32%           
===============================================
  Files                   ?      144           
  Lines                   ?    22696           
  Branches                ?        0           
===============================================
  Hits                    ?    19593           
  Misses                  ?     3103           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6025f2b...1e5754d. Read the comment docs.

PointKernel
PointKernel approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor non-blocking suggestion.

@karthikeyann
Copy link
Contributor Author

rerun tests

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ad00e44 into rapidsai:branch-22.08 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @ttnghia @PointKernel